[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnutls-dev] Re: OpenCDK indexing fails if a public key is at offset 0
From: |
Simon Josefsson |
Subject: |
[gnutls-dev] Re: OpenCDK indexing fails if a public key is at offset 0 |
Date: |
Mon, 18 Sep 2006 11:18:05 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) |
"Adam Langley" <address@hidden> writes:
> (from the opencdk sources included in gnutls-1.4.4:
>
> keydb.c:208
>
> *r_off is set to 0 and, at line, 223, if processing hasn't set this
> not a non-zero number CDK_EOF is returned. However, if we are
> searching for a key at offset 0, this returns CDK_EOF anyway.
>
> I suggest setting *r_off to 0xffffffffu and testing != to this value
> at 223. (I've made this patch locally and it's working fine for me. I
> guess we have to hope noone has >4GB of key data.)
Makes sense to me. I believe I have fixed this in gnutls CVS trunk,
please check.
Thanks,
Simon