[gnutls-dev] [PATCH] Memory leak in `_gnutls_dsa_verify ()'

[Ludovic Courtès]

Hi,

The patch below fixes a tiny memory leak.

Thanks,
Ludovic.

>From cdf2f9319d69f5eebebc70b0a369be61cc421c2a Mon Sep 17 00:00:00 2001
From: Ludovic Courtes <address@hidden>
Date: Tue, 26 Jun 2007 00:52:18 +0200
Subject: [PATCH] Fixed memory leak in `_gnutls_dsa_verify ()'.

* lib/gnutls_pk.c (_gnutls_dsa_verify): Release `rs[0]' and `rs[1]'
  when done.
---
 lib/gnutls_pk.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/lib/gnutls_pk.c b/lib/gnutls_pk.c
index c1c3902..528255b 100644
--- a/lib/gnutls_pk.c
+++ b/lib/gnutls_pk.c
@@ -553,12 +553,16 @@ _gnutls_dsa_verify (const gnutls_datum_t * vdata,
   if (_gnutls_mpi_scan_nz (&mdata, vdata->data, &k) != 0)
     {
       gnutls_assert ();
+      _gnutls_mpi_release (&rs[0]);
+      _gnutls_mpi_release (&rs[1]);
       return GNUTLS_E_MPI_SCAN_FAILED;
     }
 
   /* decrypt signature */
   ret = _gnutls_pk_verify (GCRY_PK_DSA, mdata, rs, params, params_len);
   _gnutls_mpi_release (&mdata);
+  _gnutls_mpi_release (&rs[0]);
+  _gnutls_mpi_release (&rs[1]);
 
   if (ret < 0)
     {
-- 
1.5.2.1