Re: [PATCH] Provide a gnutls_x509_crt_verify_hash

[Nikos Mavrogiannopoulos]

Cedric BAIL wrote:

>>> Btw, there is some problem in the code:
>>>
>>> verify.c: In function '_pkcs1_rsa_verify_sig':
>>> verify.c:667: error: assignment from incompatible pointer type
>> The code seems broken, this assignment:
>>
>>       cmp = &md;
>>
>> should clearly be
>>
>>       cmp = md;
> 
> Sounds better. Sorry for the mistake.
> 
>> There is another problem too:
>>
>> x509.c:2330: error: passing argument 1 of '_gnutls_x509_verify_algorithm' 
>> from incompatible pointer type
> 
> As I did send the patch against 2.7.6, the first argument of
> _gnutls_x509_verify_algorithm should be "gnutls_mac_algorithm_t
> *hash". So it should not raise any warning.

I have applied some fixes for these issues but it would be nice to send
some example code that uses those functions in order to have a test case
 for them.

regards,
Nikos