[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] client-side TLS 1.2 support
From: |
Simon Josefsson |
Subject: |
Re: [PATCH] client-side TLS 1.2 support |
Date: |
Mon, 31 Aug 2009 15:04:10 +0200 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
Daiki Ueno <address@hidden> writes:
>>>>>> In <address@hidden>
>>>>>> Simon Josefsson <address@hidden> wrote:
>> > +#define TLS_SIGN_AID_RSA_SHA1 {2, 1}
>> > +#define TLS_SIGN_AID_RSA_SHA256 {4, 1}
>> > +#define TLS_SIGN_AID_RSA_SHA384 {5, 1}
>> > +#define TLS_SIGN_AID_RSA_SHA512 {6, 1}
>> > +#define TLS_SIGN_AID_DSA_SHA1 {2, 2}
>> > +#define TLS_SIGN_AID_RSA_MD5 {1, 2}
>
>> Where does these "magic" values come from? It was these values that I
>> would prefer to use symbolic names for.
>
> RFC5246 7.4.1.4.1. defines those values as:
>
> enum {
> none(0), md5(1), sha1(2), sha224(3), sha256(4), sha384(5),
> sha512(6), (255)
> } HashAlgorithm;
>
> enum { anonymous(0), rsa(1), dsa(2), ecdsa(3), (255) }
> SignatureAlgorithm;
Thanks, I pushed your patches and added a comment explaining this.
> I first thought of redefining GNUTLS_SIGN_* with pairs of those values
> (like cipher suites definitions), but it will break the ABI...
Right, it is not worth it.
/Simon
- ECC cipher suites, Daiki Ueno, 2009/08/25
- Re: ECC cipher suites, Simon Josefsson, 2009/08/25
- Re: ECC cipher suites, Daiki Ueno, 2009/08/27
- Poll: What do you want to see implemented in GnuTLS next?, Simon Josefsson, 2009/08/27
- [PATCH] client-side TLS 1.2 support, Daiki Ueno, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support, Simon Josefsson, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support, Daiki Ueno, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support, Simon Josefsson, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support, Daiki Ueno, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support, Daiki Ueno, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support,
Simon Josefsson <=
- Re: [PATCH] client-side TLS 1.2 support, Simon Josefsson, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support, Simon Josefsson, 2009/08/31
- Re: [PATCH] client-side TLS 1.2 support, Simon Josefsson, 2009/08/31
- [PATCH] add SHA-2 ciphersuites, Daiki Ueno, 2009/08/31