From 0cb1cc33c45c2da19f8e685fe3f6209fd5e03cc4 Mon Sep 17 00:00:00 2001 From: Fabian Keil Date: Tue, 25 Aug 2009 18:15:35 +0200 Subject: [PATCH 07/17] Mark what looks like a bug in in _gnutls_srp_pwd_read_entry() --- lib/auth_srp_passwd.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/auth_srp_passwd.c b/lib/auth_srp_passwd.c index 4475abb..376effd 100644 --- a/lib/auth_srp_passwd.c +++ b/lib/auth_srp_passwd.c @@ -347,7 +347,8 @@ _gnutls_srp_pwd_read_entry (gnutls_session_t state, char *username, /* Keep the last index in memory, so we can retrieve fake parameters (g,n) * when the user does not exist. */ - last_idx = idx; + /* XXX: last_idx will not be read as both if block branches return. */ + last_idx = idx; if (pwd_read_conf (cred->password_conf_file, entry, idx) == 0) { return 0; -- 1.6.4.1