[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] Request for review - X509 Issuer Altname handling
|
From: |
Simon Josefsson |
|
Subject: |
Re: [patch] Request for review - X509 Issuer Altname handling |
|
Date: |
Mon, 07 Sep 2009 17:59:09 +0200 |
|
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
Brad Hards <address@hidden> writes:
> I've updated the patch to include the self-test. It is otherwise unchanged.
Thank you! It looks fine except one nit:
The code duplication between print_san and print_ian worries me, and the
print_san code has been changed since you made the patch so they are not
in sync with your patch. Could you instead generalize print_san into a
print_an function that takes an additional parameter indicating whether
it is printing a SAN or IAN?
With that change, it is ready to go in.
/Simon