[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: _gnutls_hostname_compare: toupper vs. c_toupper
From: |
Nikos Mavrogiannopoulos |
Subject: |
Re: _gnutls_hostname_compare: toupper vs. c_toupper |
Date: |
Thu, 05 May 2011 22:18:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110223 Thunderbird/3.1.8 |
On 05/03/2011 10:53 PM, Kalle Olavi Niemitalo wrote:
> In GnuTLS 2.8.6 and 2.10.5, _gnutls_hostname_compare uses toupper
> on the characters of the hostname:
>
> /* find the first different character */
> for (; *certname && *hostname && toupper (*certname) == toupper (*hostname);
> certname++, hostname++, certnamesize--)
> ;
> I suspect this should be c_toupper instead, so that 'i' matches
> 'I' in hostnames even in a Turkish (or is that Turkic?) locale.
You're right. This however makes it apparent that
gnutls_x509_crt_check_hostname() does not really support
internationalized DNS names...
Thank you for reporting that.
regards,
Nikos