gnutls-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Patch] Fix nonblocking DTLS


From: Sean Buckheister
Subject: [Patch] Fix nonblocking DTLS
Date: Wed, 15 Feb 2012 03:55:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120212 Thunderbird/10.0.1

Hi,

after seeing lots and lots of failures in nonblocking DTLS handshakes, I
went digging through code and packet traces. I found that a gnutls
server will not retransmit it's last handshake flight for nonblocking,
nonresuming session, while the client would continue to request such
retransmission by duplicating it's respective last flight. Ultimately,
this would lead to timeouts.

The offending piece of code is gnutls_dtls.c, _dtls_transmit, lines
254-255. Removing those sort of fixed DTLS -nb, i.e. all 18432 handshake
sequence trials of dtls-stress passed. make check passed as well.

There should be no problem removing these two lines, as _dtls_transmit
is only called directly when a handshake sequence should be flushed, and
indirectly when a handshake packet was received when none were expected.
A patch is attached, please let me know what you think.


 -- Sean

Attachment: dtls.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]