Re: Memory leak in initialize_automatic_p11_kit()

[Daniel Kahn Gillmor]

On Thu 2012-02-23 02:44:52 -0500, Nikos Mavrogiannopoulos wrote:

> On 02/23/2012 12:13 AM, Sam Varshavchik wrote:
>
>> Valgrind is complaining about a minor memory leak. Looks like it's
>> happening only once, on initialization. But, it's still a leak.
>> 
>> ==21602==    at 0x4A074CD: malloc (vg_replace_malloc.c:236)
>> ==21602==    by 0x33D4486A81: strdup (in /lib64/libc-2.14.90.so)
>> ==21602==    by 0x33DB805907: p11_kit_registered_module_to_name (in
>> /usr/lib64/libp11-kit.so.0.0.0)
>> ==21602==    by 0x3F70C48524: gnutls_pkcs11_init (in
>> /usr/lib64/libgnutls.so.26.21.8)
>> 
>> Looking at the code, p11_kit_registered_module_to_name() returns a
>> malloced buffer, which the caller seems to be responsible for freeing,
>> and initialize_automatic_p11_kit() does not do that.
>
>
> Thank you. Corrected.

I've just corrected this leak on the gnutls_2_12_x branch in git as
well.

        --dkg

pgpovhfydloVy.pgp
Description: PGP signature