gpsd-commit-watch
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-517


From: Fred Wright
Subject: [gpsd-commit-watch] [SCM] GPSD branch, master, updated. release-3.16-517-gd1fd9ad
Date: Tue, 20 Dec 2016 20:52:47 +0000 (UTC)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GPSD".

The branch, master has been updated
       via  d1fd9ad44f320235b4d449988570ab5633f21bab (commit)
      from  a90375433424585e4a748f9b495eb8785f50a1fb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d1fd9ad44f320235b4d449988570ab5633f21bab
Author: Fred Wright <address@hidden>
Date:   Tue Dec 20 12:18:23 2016 -0800

    Fixes spurious GSV warning on multi-GNSS receivers.
    
    This bug was intended to be fixed by commit 074499e16.  The problem is
    that the total satellite count in xxGSV sentences is per-talker rather
    than global, but the sanity check only has the global total available
    for comparison.  The original change attempted to fix this by
    suppressing the check whenever non-GPS talkers are detected (in the
    current cycle), on the assumption that GPGSV blocks always come first.
    Thus, the GPGSV total would be checked, but not the others.  However,
    the sense of the conditional was inverted, disabling the check for
    GPGSV while causing it to produce bogus warnings in most multi-GNSS
    cases.  This change corrects that.
    
    The proper fix for this would be to implement per-talker satellite
    totals.  There's now a FIXME to that effect.
    
    TESTED:
    All regression tests pass, and running gpsmon against a GPS/GLONASS
    receiver no longer produces spurious warnings (when enabled).

-----------------------------------------------------------------------

Summary of changes:
 driver_nmea0183.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
GPSD



reply via email to

[Prev in Thread] Current Thread [Next in Thread]