Re: [gpsd-dev] revert commit d1965788249d7e22cdde4021d452cf0dc6c6b9bd

[Zbigniew Chyla]

Hi Gary,

Sorry for inconvenience. I didn't notice this because I didn't have qt 
headers on my machine.

Attached smaller version of the change with problematic parts removed.

The source of the problem is that:
 a) some files are compiled using either C or C++ compiler, depending 
on the configuration;
 b) there's no implicit assignment operator for volatile in C++.

Are you guys sure, that building the same source file with both C++ and 
C compilers (depending on the configuration) is a good idea? I'd be 
afraid of subtle differences in source code interpretation between both 
languages.

BR
Zbigniew


On 29.04.2015 03:17, ext Gary E. Miller wrote:
> Yo All!
>
> My git head was broken by commit d1965788249d7e22cdde4021d452cf0dc6c6b9bd.
>
> It breaks my build on Gentoo running gcc 4.9.2
>      
>      libgps_shm.c: In function 'int gps_shm_read(gps_data_t*)':
>      libgps_shm.c:122:12: error: no match for 'operator=' (operand types are
>      'gps_data_t' and 'volatile gps_data_t')
>        noclobber = shared->gpsdata;
>                  ^
>      libgps_shm.c:122:12: note: candidate is:
>      In file included from gpsd.h:350:0,
>                       from libgps_shm.c:30:
>      gps.h:1918:8: note: gps_data_t& gps_data_t::operator=(const gps_data_t&)
>       struct gps_data_t {
>              ^
>      gps.h:1918:8: note:   no known conversion for argument 1 from 'volatile
>      gps_data_t' to 'const gps_data_t&'
>
> I just reverted it, the whole thing.  The commit touched several files,
> Most of the commit is probably good, so Zbigniew needs to split that up
> into smaller commits to allow us to troubleshoot it.
>
> RGDS
> GARY
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97701
>         address@hidden  Tel:+1(541)382-8588

0001-Copy-structs-using-assignment-not-memcpy.patch
Description: Text Data