[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH 6/8] Shift JSON_DATE_MAX definition so shared_json
|
From: |
Gary E. Miller |
|
Subject: |
Re: [gpsd-dev] [PATCH 6/8] Shift JSON_DATE_MAX definition so shared_json.c doesn't need to rely on gpsd.h |
|
Date: |
Tue, 19 Apr 2016 17:24:34 -0700 |
Yo Robert!
On Wed, 20 Apr 2016 01:07:53 +0100
Robert Norris <address@hidden> wrote:
> I moved the JSON_DATE_MAX to be in an accessible place as code for
> building both (lib)gpsd and libgps requires it.
I agree with the motivation, but as a non-Python person putting it in
SConstruct is not making it more acccessible to a C-guy.
I'm not a fan of auto-gernating things that should never change.
> I suppose one could instead to move these fixed parts to be in a
> separate file (e.g. gpsd_definitions.h) that gets included in
> gpsd_config.h.
Yeah, some new header file that is for common parts between gpsd and
clients.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1 541 382 8588
pgpEmf2vmQIEL.pgp
Description: OpenPGP digital signature