Re: [gpsd-dev] [PATCH] include sys/sysmacros.h for major

[Gary E. Miller]

Yo Mike!

On Mon, 9 May 2016 22:04:19 -0400
Mike Frysinger <address@hidden> wrote:

> On 09 May 2016 13:46, Gary E. Miller wrote:
> > On Mon,  9 May 2016 14:44:48 -0400 Mike Frysinger wrote:  
> > > These functions are not part of any official spec, and Linux C
> > > libs have always kept them in sys/sysmacros.h.  Include the header
> > > directly to fix builds w/alternative C libs, and to work with
> > > future glibc versions. ---  
> > 
> > Can you be specific on what distro or version this may fix?  
> 
> it isn't deployed yet.  gpsd can wait for newer C lib releases to
> break its build, or it can get ahead like every other project i've
> sent patches to and fix their source trees now.

I do not find 'because everyone else does' a compelling reason.  Can
you point to a single thing released, beta or even git head, that
needs this?  Or some statement from glibc of future direction?

We need a little bit more than "Mike said so".

> this isn't specific to Linux either.  it's long been an issue for
> other OS's which is why autoconf has had a macro for this for more
> than a decade.  see AC_HEADER_MAJOR:
>       
> https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Particular-Headers.html

If autoconfuse does it I find that somewhat compelling.  But all they
do is set MAJOR_IN_SYSMACROS.  Do we know of any cases that use that
define?

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

pgpdRde9IHl2B.pgp
Description: OpenPGP digital signature