Re: [gpsd-dev] build broken on FreeBSD

[Eric S. Raymond]

Hal Murray <address@hidden>:
> 
> gpsmon.c:61:22: error: use of undeclared identifier 'HOST_NAME_MAX'
> static char hostname[HOST_NAME_MAX];
> 
> $  grep HOST_NAME_MAX /usr/include/ -r
> /usr/include/sys/syslimits.h: * HOST_NAME_MAX
> /usr/include/limits.h:#define   _POSIX_HOST_NAME_MAX    255
> /usr/include/unistd.h:#define   _SC_HOST_NAME_MAX       72
> $
> 
> >From /usr/include/sys/syslimits.h
> 
> /*
>  * We leave the following values undefined to force applications to either
>  * assume conservative values or call sysconf() to get the current value.
>  *
>  * HOST_NAME_MAX
>  * 
>  * (We should do this for most of the values currently defined here,
>  * but many programs are not prepared to deal with this yet.)
>  */
> 
> 
> Also:
> 
> gpsd.c:303:32: warning: comparison of integers of different signs: 'int' and 
> 'un
> signed int' [-Wsign-compare]
>             for (maxfd = tfd = 0; tfd < FD_SETSIZE; tfd++)
>                                   ~~~ ^ ~~~~~~~~~~
> gpsd.c:2476:44: warning: format specifies type 'int' but the argument has 
> type '
> sig_atomic_t' (aka 'long') [-Wformat]
>              "received terminating signal %d.\n", signalled);
>                                           ~~      ^~~~~~~~~
>                                           %ld
> gpsd.c:2195:65: warning: comparison of integers of different signs: 
> 'socket_t' (
> aka 'int') and 'unsigned int' [-Wsign-compare]
>                     && (0 <= device->gpsdata.gps_fd && device->gpsdata.gps_fd 
> <
> FD_SETSIZE)
> 
> 
> -- 
> These are my opinions.  I hate spam.
> 
> 
> 

Attempted fixes pushed, thanks.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>