gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Ensure all functions of the client API are availa


From: Gary E. Miller
Subject: Re: [gpsd-dev] [PATCH] Ensure all functions of the client API are available at all times.
Date: Tue, 2 Aug 2016 16:59:47 -0700

Yo Robert!

Looks good, but I made on change in the commit comment.  gpsd likes
to keep lines under 80 chars long.

Patch applied.

On Sat, 30 Jul 2016 18:08:50 +0000
Robert Norris <address@hidden> wrote:

> Thus client programs won't fail to build or run due to missing
> functions. Although when clientdebug is turned off in building
> libgps, then these functions won't do anything. ---
>  libgps_core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libgps_core.c b/libgps_core.c
> index 582e210..ca580bd 100644
> --- a/libgps_core.c
> +++ b/libgps_core.c
> @@ -49,6 +49,10 @@ void libgps_trace(int errlevel, const char
> *fmt, ...) (void)fputs(buf, debugfp);
>      }
>  }
> +#else
> +// Functions defined as so to furfil the API but otherwise do
> nothing when built with debug capability turned off +void
> gps_enable_debug(int level UNUSED, FILE * fp UNUSED) {} +void
> libgps_trace(int errlevel UNUSED, const char *fmt UNUSED, ...){}
> #endif /* LIBGPS_DEBUG */ 
>  #ifdef SOCKET_EXPORT_ENABLE




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

Attachment: pgpoWgP5V9Mcz.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]