gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Fix SConstruct to work with Python 3


From: teyrana
Subject: Re: [gpsd-dev] [PATCH] Fix SConstruct to work with Python 3
Date: Mon, 12 Feb 2018 18:08:46 -0500

Perhaps we're all talking about different cases?

1. python2 only:
     already implemented
2. python 3 only:
   Robert Norris's patch, above
3. python2 and python3:
   my problem.

To clarify what I mean, I went ahead and implemented a patch (attached). However, it should probably have input from someone who knows the Sconstruct file a bit better...
Particularly, I'm worried about the side affects of the `GetPythonValue` function.

Tested to works on my system: (Ubuntu 16.03 LTS, with both python2.7 & python3.5), but further testing wouldn't hurt.

Cheers,
-Dan


Daniel Williams
address@hidden
858-220-8134 (Mobile)
339-368-6425 (Skype)
LinkedIn
GitHub



Daniel Williams
address@hidden
858-220-8134 (Mobile)
339-368-6425 (Skype)
LinkedIn
GitHub

On Mon, Feb 12, 2018 at 5:24 PM, Gary E. Miller <address@hidden> wrote:
Yo Robert!

On Mon, 12 Feb 2018 20:41:28 +0000
Robert Norris <address@hidden> wrote:

> Note that this patch is as used on:
> https://build.opensuse.org/package/show/windows:mingw:win32/mingw32-libgps

Thanks!  Patch applies, pushed to git head.


RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

Attachment: python2and3.scons.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]