grep-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Grep-devel] [PATCH] grep: use 'j' printf length modifier for [u]int


From: Paul Eggert
Subject: Re: [Grep-devel] [PATCH] grep: use 'j' printf length modifier for [u]intmax_t
Date: Sun, 16 Oct 2016 23:43:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

Jim Meyering wrote:
I found that gettext has been using %j in one of its
tools for over two years

While encouraging, gettext's users are developers who tend to use more up-to-date libraries, whereas grep is an end-user tool that is more likely to run atop ancient libraries. And if the libraries don't work, failures will be at run-time and plausibily will occur only with large inputs that our test cases won't match.

Before installing this patch, how about if we run gl_PRINTF_SIZES_C99 at configure-time, and have 'configure' fail on platforms where $gl_cv_func_printf_sizes_c99 is not 'yes'? That would nip these sorts of problems in the bud.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]