groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 01/01: Use gnulib's 'hypot' module.


From: Bertrand Garrigues
Subject: [groff] 01/01: Use gnulib's 'hypot' module.
Date: Sat, 8 Dec 2018 18:14:02 -0500 (EST)

bgarrigues pushed a commit to branch master
in repository groff.

commit dd3d602cd25447fa8f4b5471a0ade882dc89032a
Author: Bertrand Garrigues <address@hidden>
Date:   Sun Dec 9 00:06:31 2018 +0100

    Use gnulib's 'hypot' module.
    
    In 'configure.ac', the macro call
    'GROFF_NEED_DECLARATION([hypot])' checks whether the function
    'hypot' is correctly declared in 'math.h', but the test is buggy
    and may yields false results.
    
    * bootsrap.conf: add 'hypot' module.
    
    * configure.ac: Remove GROFF_NEED_DECLARATION([hypot]).
    
    * src/libs/libgroff/hypot.cpp: remove declaration of hypot.
---
 ChangeLog                   | 15 +++++++++++++++
 bootstrap.conf              |  1 +
 configure.ac                |  1 -
 src/libs/libgroff/hypot.cpp |  4 ----
 4 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fc192ec..1322f6a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,18 @@
+2018-12-08 Bertrand Garrigues <address@hidden>
+
+       Use gnulib's 'hypot' module.
+
+       In 'configure.ac', the macro call
+       'GROFF_NEED_DECLARATION([hypot])' checks whether the function
+       'hypot' is correctly declared in 'math.h', but the test is buggy
+       and may yields false results.
+
+       * bootsrap.conf: add 'hypot' module.
+
+       * configure.ac: Remove GROFF_NEED_DECLARATION([hypot]).
+
+       * src/libs/libgroff/hypot.cpp: remove declaration of hypot.
+
 2018-12-07  Deri James  <address@hidden>
 
        Problem running gropdf on big endian (Sparc)
diff --git a/bootstrap.conf b/bootstrap.conf
index 5161d1f..6cf16c8 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -43,6 +43,7 @@ gnulib_modules="
     fprintf-posix
     snprintf
     vsnprintf
+    hypot
 "
 
 # Name of the Makefile.am
diff --git a/configure.ac b/configure.ac
index cb2bd10..e0a049f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -95,7 +95,6 @@ GROFF_POSIX
 # checks for header stuff
 GROFF_SRAND
 GROFF_NEED_DECLARATION([gettimeofday])
-GROFF_NEED_DECLARATION([hypot])
 GROFF_NEED_DECLARATION([popen])
 GROFF_NEED_DECLARATION([pclose])
 GROFF_NEED_DECLARATION([putenv])
diff --git a/src/libs/libgroff/hypot.cpp b/src/libs/libgroff/hypot.cpp
index 3eb2fb9..1fa44d4 100644
--- a/src/libs/libgroff/hypot.cpp
+++ b/src/libs/libgroff/hypot.cpp
@@ -20,10 +20,6 @@ along with this program.  If not, see 
<http://www.gnu.org/licenses/>.  */
 
 #include <math.h>
 
-#ifdef NEED_DECLARATION_HYPOT
-  double hypot(double, double);
-#endif /* NEED_DECLARATION_HYPOT */
-  
 double groff_hypot(double x, double y)
 {
   double result = hypot(x, y);



reply via email to

[Prev in Thread] Current Thread [Next in Thread]