groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 01/01: Remove the unused variables PREFIXMAN5 and PREFIXMAN7.


From: Ingo Schwarze
Subject: [groff] 01/01: Remove the unused variables PREFIXMAN5 and PREFIXMAN7.
Date: Mon, 10 Dec 2018 18:32:31 -0500 (EST)

schwarze pushed a commit to branch master
in repository groff.

commit 99bbe617fdc8f4a85bac9a606081857a3c0374ad
Author: Ingo Schwarze <address@hidden>
Date:   Mon Dec 10 23:36:08 2018 +0100

    Remove the unused variables PREFIXMAN5 and PREFIXMAN7.
    
    They caused portability trouble because they resulted in
    commands of the form:  "for f in ; do $something ; done"
    Even though such empty loops are valid POSIX syntax,
    they cause the default sh(1) on Solaris 9 to die.
    
    Thanks to wl@ for insisting that the Solaris 9 failure
    ought to be fixed; without that, the fact that these
    variables are unused would not have been found.
    
    OK bgarrigues@ gbranden@
---
 ChangeLog   |  7 ++++++-
 Makefile.am | 18 +-----------------
 2 files changed, 7 insertions(+), 18 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index fb82245..854cc2c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2018-12-10 Ingo Schwarze <address@hidden>
+
+       * Makefile.am: Remove the unused variables PREFIXMAN5 and PREFIXMAN7.
+
+       They caused installation failures on Solaris 9.
+
 2018-12-08 Bertrand Garrigues <address@hidden>
 
        Remove gnulib's hypot module.
@@ -24,7 +30,6 @@
        In 'configure.ac', the macro call
        'GROFF_NEED_DECLARATION([hypot])' checks whether the function
        'hypot' is correctly declared in 'math.h', but the test is buggy
-
        and may yields false results.
 
        * bootsrap.conf: add 'hypot' module.
diff --git a/Makefile.am b/Makefile.am
index f23038f..d18c49b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -552,8 +552,6 @@ CLEANFILES =
 EXTRA_DIST = gnulib_m4/gnulib-cache.m4
 FONTFILES =
 PREFIXMAN1 =
-PREFIXMAN5 =
-PREFIXMAN7 =
 man1_MANS =
 man5_MANS =
 man7_MANS =
@@ -738,26 +736,12 @@ install-prefix-man:
        for f in $(PREFIXMAN1); do \
          cp -f $$f $(DESTDIR)$(man1dir)/$(NAMEPREFIX)`basename $$f`; \
        done
-       for f in $(PREFIXMAN5); do \
-         cp -f $$f $(DESTDIR)$(man5dir)/$(NAMEPREFIX)`basename $$f`; \
-       done
-       for f in $(PREFIXMAN7); do \
-         cp -f $$f $(DESTDIR)$(man7dir)/$(NAMEPREFIX)`basename $$f`; \
-       done
 uninstall-prefix-man:
        for f in $(PREFIXMAN1); do \
          rm -f $(DESTDIR)$(man1dir)/$(NAMEPREFIX)`basename $$f`; \
        done
-       for f in $(PREFIXMAN5); do \
-         rm -f $(DESTDIR)$(man5dir)/$(NAMEPREFIX)`basename $$f`; \
-       done
-       for f in $(PREFIXMAN7); do \
-         rm -f $(DESTDIR)$(man7dir)/$(NAMEPREFIX)`basename $$f`; \
-       done
 else
 man1_MANS += $(PREFIXMAN1)
-man5_MANS += $(PREFIXMAN5)
-man7_MANS += $(PREFIXMAN7)
 install-prefix-man:
 uninstall-prefix-man:
 generate_man_files:
@@ -872,7 +856,7 @@ EXTRA_DIST += \
 
 MOSTLYCLEANFILES += $(prefixexecbin_SCRIPTS) $(bin_SCRIPTS) \
   $(man1_MANS) $(man5_MANS) $(man7_MANS) \
-  $(PREFIXMAN1) $(PREFIXMAN5) $(PREFIXMAN7) \
+  $(PREFIXMAN1) \
   test-groff
 
 # Suffix rule to build .1, .5 and .7 files from .1.man, .5.man and



reply via email to

[Prev in Thread] Current Thread [Next in Thread]