groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 09/11: src/preproc/html/pre-html.cpp: Trivially refactor.


From: G. Branden Robinson
Subject: [groff] 09/11: src/preproc/html/pre-html.cpp: Trivially refactor.
Date: Mon, 27 Nov 2023 15:52:12 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit f32fbb4709ae623b1c26a010007b77040bd433cc
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Mon Nov 27 13:48:47 2023 -0600

    src/preproc/html/pre-html.cpp: Trivially refactor.
    
    * src/preproc/html/pre-html.cpp (makeTempFiles): Stop explicitly
      specifying parameters redundantly with their default values.
    
    Incidentally, no `xtmpfile()` callers in the tree actually _use_ its
    final argument now.
---
 ChangeLog                     | 5 +++++
 src/preproc/html/pre-html.cpp | 9 ++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e6d9f2556..9d9ea1d8e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2023-11-27  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * src/preproc/html/pre-html.cpp (makeTempFiles): Stop explicitly
+       specifying parameters redundantly with their default values.
+
 2023-11-27  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [libgroff]: Trivially refactor `xtmpfile`.
diff --git a/src/preproc/html/pre-html.cpp b/src/preproc/html/pre-html.cpp
index 69288ea9f..cbcc2ccda 100644
--- a/src/preproc/html/pre-html.cpp
+++ b/src/preproc/html/pre-html.cpp
@@ -1713,20 +1713,19 @@ static void makeTempFiles(void)
   FILE *f;
 
   // psPageName contains a single page of PostScript.
-  f = xtmpfile(&psPageName, PS_TEMPLATE_LONG, PS_TEMPLATE_SHORT, true);
+  f = xtmpfile(&psPageName, PS_TEMPLATE_LONG, PS_TEMPLATE_SHORT);
   if (0 /* nullptr */ == f)
     sys_fatal("xtmpfile");
   fclose(f);
 
   // imagePageName contains a bitmap image of a single PostScript page.
-  f = xtmpfile(&imagePageName, PAGE_TEMPLATE_LONG, PAGE_TEMPLATE_SHORT,
-              true);
+  f = xtmpfile(&imagePageName, PAGE_TEMPLATE_LONG, PAGE_TEMPLATE_SHORT);
   if (0 /* nullptr */ == f)
     sys_fatal("xtmpfile");
   fclose(f);
 
   // psFileName contains a PostScript file of the complete document.
-  f = xtmpfile(&psFileName, PS_TEMPLATE_LONG, PS_TEMPLATE_SHORT, true);
+  f = xtmpfile(&psFileName, PS_TEMPLATE_LONG, PS_TEMPLATE_SHORT);
   if (0 /* nullptr */ == f)
     sys_fatal("xtmpfile");
   fclose(f);
@@ -1734,7 +1733,7 @@ static void makeTempFiles(void)
   // regionFileName contains a list of the images and their boxed
   // coordinates.
   f = xtmpfile(&regionFileName,
-              REGION_TEMPLATE_LONG, REGION_TEMPLATE_SHORT, true);
+              REGION_TEMPLATE_LONG, REGION_TEMPLATE_SHORT);
   if (0 /* nullptr */ == f)
     sys_fatal("xtmpfile");
   fclose(f);



reply via email to

[Prev in Thread] Current Thread [Next in Thread]