[groff] 05/10: src/roff/troff/input.cpp: Trivially refactor.

[G. Branden Robinson]

gbranden pushed a commit to branch master
in repository groff.

commit 1f1731a5e275179a96737f0e5f0710b4d965fae3
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sat Jan 13 06:27:47 2024 -0600

    src/roff/troff/input.cpp: Trivially refactor.
    
    * src/roff/troff/input.cpp (encode_char_for_troff_output): Qualify `c`
      argument as `const`.  Reorder comparisons to avoid inadvertent lvalue
      assignment.  (Yes--suspenders _and_ a belt.)
---
 ChangeLog                | 6 ++++++
 src/roff/troff/input.cpp | 6 +++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index f15ab215f..0d9860dde 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-01-13  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * src/roff/troff/input.cpp (encode_char_for_troff_output):
+       Qualify `c` argument as `const`.  Reorder comparisons to avoid
+       inadvertent lvalue assignment.  (Yes--suspenders _and_ a belt.)
+
 2024-01-10  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [troff]: Fix code style nits.
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 8f8df4f92..a2bb11d4e 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -5571,9 +5571,9 @@ static node *do_non_interpreted()
   return new non_interpreted_node(mac);
 }
 
-static void encode_char_for_troff_output(macro *mac, char c)
+static void encode_char_for_troff_output(macro *mac, const char c)
 {
-  if (c == '\0') {
+  if ('\0' == c) {
     if (tok.is_stretchable_space()
             || tok.is_unstretchable_space())
       mac->append(' ');
@@ -5628,7 +5628,7 @@ static void encode_char_for_troff_output(macro *mac, char 
c)
            tok.description());
   }
   else {
-    if ((font::use_charnames_in_special) && (c == '\\')) {
+    if ((font::use_charnames_in_special) && ('\\' == c)) {
       /*
        * add escape escape sequence
        */