groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 08/15: src/roff/troff/input.cpp: Fix code style nit.


From: G. Branden Robinson
Subject: [groff] 08/15: src/roff/troff/input.cpp: Fix code style nit.
Date: Thu, 1 Feb 2024 23:45:28 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 14453d31dc3907980cb09717d3490eb90d2de6a4
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Thu Feb 1 16:44:25 2024 -0600

    src/roff/troff/input.cpp: Fix code style nit.
    
    * src/roff/troff/input.cpp (token::description): Fix code style nit.
      Use `sizeof` operator instead of `strlen()` to compute length of
      string literal at compile time.  Prompted by warning from Clang 17.
---
 ChangeLog                | 7 +++++++
 src/roff/troff/input.cpp | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 1bc519678..ebbf2f305 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2024-02-01  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * src/roff/troff/input.cpp (token::description): Fix code style
+       nit.  Use `sizeof` operator instead of `strlen()` to compute
+       length of string literal at compile time.  Prompted by warning
+       from Clang 17.
+
 2024-02-01  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * tmac/an.tmac (an-end): Call `an-input-trap`.  If a document
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 39a3c8012..5b5bec470 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -2533,7 +2533,7 @@ bool token::is_usable_as_delimiter(bool report_error)
 
 const char *token::description()
 {
-  const size_t bufsz = strlen("character 'x'") + 1;
+  const size_t bufsz = sizeof "character 'x'" + 1;
   static char buf[bufsz];
   (void) memset(buf, 0, bufsz);
   switch (type) {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]