[groff] 29/48: [troff]: Boolify env.cpp (20/25).

[G. Branden Robinson]

gbranden pushed a commit to branch master
in repository groff.

commit a5a2a249748cc60bee15e0012cbc96b339c7c84a
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sat Apr 27 05:06:33 2024 -0500

    [troff]: Boolify env.cpp (20/25).
    
    [troff]: Boolify more `environment` class member variables, member
    function parameters, and local variables.
    
    * src/roff/troff/env.h (class environment): Demote member variable
      `dummy` from `int` to `bool`.
    * src/roff/troff/env.cpp (environment::environment): Assign Boolean
      literals to it.
    * src/roff/troff/env.h (environment::is_dummy): Return a `bool`, not an
      `int`.
---
 ChangeLog              | 7 +++++++
 src/roff/troff/env.cpp | 4 ++--
 src/roff/troff/env.h   | 4 ++--
 3 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0b29021d0..cb12fea06 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -157,6 +157,13 @@
        variable `err` to `is_valid`, invert its sense, and demote it
        from `int` to `bool`.  Assign Boolean literals to it.
 
+       * src/roff/troff/env.h (class environment): Demote member
+       variable `dummy` from `int` to `bool`.
+       * src/roff/troff/env.cpp (environment::environment): Assign
+       Boolean literals to it.
+       * src/roff/troff/env.h (environment::is_dummy): Return a
+       `bool`, not an `int`.
+
 2024-04-24  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * src/roff/troff/env.cpp (tab_stops::to_string)
diff --git a/src/roff/troff/env.cpp b/src/roff/troff/env.cpp
index e6806ac47..1e5f3b53c 100644
--- a/src/roff/troff/env.cpp
+++ b/src/roff/troff/env.cpp
@@ -684,7 +684,7 @@ void environment::set_fill_color(color *c)
 }
 
 environment::environment(symbol nm)
-: dummy(0),
+: dummy(false),
   prev_line_length((units_per_inch*13)/2),
   line_length((units_per_inch*13)/2),
   prev_title_length((units_per_inch*13)/2),
@@ -774,7 +774,7 @@ environment::environment(symbol nm)
 }
 
 environment::environment(const environment *e)
-: dummy(1),
+: dummy(true),
   prev_line_length(e->prev_line_length),
   line_length(e->line_length),
   prev_title_length(e->prev_title_length),
diff --git a/src/roff/troff/env.h b/src/roff/troff/env.h
index 4cae56346..68b82e9a4 100644
--- a/src/roff/troff/env.h
+++ b/src/roff/troff/env.h
@@ -140,7 +140,7 @@ void widow_control_request();
 #endif /* WIDOW_CONTROL */
 
 class environment {
-  int dummy;                   // dummy environment used for \w
+  bool dummy;                  // dummy environment used for \w
   hunits prev_line_length;
   hunits line_length;
   hunits prev_title_length;
@@ -268,7 +268,7 @@ public:
   statem *construct_state(bool has_only_eol);
   void print_env();
   void copy(const environment *);
-  int is_dummy() { return dummy; }
+  bool is_dummy() { return dummy; }
   int is_empty();
   bool is_composite() { return composite; }
   void set_composite() { composite = true; }