[Groff] another parallel build race failure

[Ingo Schwarze]

Hi Werner,

having seen your recent commit to contrib/pdfroff/Makefile.sub,
i remembered that parallel build failures had been seen in the
OpenBSD port of groff-1.21, and with the help of build logs
provided by naddy@, i think i figured out what happens.
(If you need it, i can forward the build log to you.)

Some hdtbl and mom examples want PostScript formatting which
requires the DESC file to be ready; however, the top-level
Makefile.in doesn't currently enforce the proper order of
building of font/dev before contrib/hdtbl, contrib/mom and so on.

Given that font/dev and the contrib examples are in different
child processes of the recursive make system, it doesn't seem
possible to solve this using clean Makefile dependencies;
so i fear the order must be enforced by splitting the shell
command invoking recursive make in the top level Makefile.in.

Yours,
  Ingo


Index: Makefile.in
===================================================================
RCS file: /sources/groff/groff/Makefile.in,v
retrieving revision 1.118
diff -u -r1.118 Makefile.in
--- Makefile.in 10 Aug 2011 18:22:59 -0000      1.118
+++ Makefile.in 26 Dec 2011 21:57:37 -0000
@@ -624,8 +624,8 @@
   $(DEVDIRS) \
   $(XDEVDIRS) \
   $(OTHERDEVDIRS) \
-  $(TTYDEVDIRS) \
-  $(OTHERDIRS)
+  $(TTYDEVDIRS)
+# $(OTHERDIRS)
 EXTRADIRS=\
   font/devps/generate \
   font/devdvi/generate \
@@ -686,13 +686,14 @@
        fi
 
 do=all
-dodirs=$(ALLDIRS) dot
+dodirs=$(ALLDIRS) $(OTHERDIRS) dot
 # Default target for subdir_Makefile
 subdir=src/roff/troff
 
 
 $(TARGETS):
-       @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) do=$@ $(dodirs)
+       @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) do=$@ $(ALLDIRS)
+       @$(ENVSETUP); $(MAKE) $(MAKE_K_FLAG) do=$@ $(OTHERDIRS) dot
 
 dot: FORCE
        @$(ENVSETUP); \