groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] Automake migration proposal


From: Werner LEMBERG
Subject: Re: [Groff] Automake migration proposal
Date: Tue, 12 Aug 2014 08:02:31 +0200 (CEST)

> The following patch fixes the problem.

Thanks again for your thorough tests!

> Now how do we proceed?  I guess the problems found so far should be
> fixed in the automake branch in any case.  However, what i found is
> merely what i inadvertently bumped into.  There are no doubt more
> bugs, and bugs like the one below are *very* hard to find in a code
> audit of a 150 thousand line diff.  So who is really sure the diff
> is of sufficient quality to merge it?  I am certainly not, and the
> three subtle bugs i ran into without even starting a real audit do
> not make me any more confident.

Well, your suggestion of splitting the patch into smaller units is the
way to go, I reckon.  In case it improves legibility, I don't mind if
there is a series of commits that don't compile – simply tag them as
such in the commit message.


    Werner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]