[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Compiling grub2 on *BSD?
From: |
Marco Gerards |
Subject: |
Re: Compiling grub2 on *BSD? |
Date: |
Mon, 28 Jan 2008 13:56:26 +0100 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Robert Millan <address@hidden> writes:
>> > - movsbl %dh, %eax
>> > - movl %eax, %ss:(DATA_ADDR +
>> > GRUB_KERNEL_MACHINE_INSTALL_DOS_PART)
>> > + // Check for the multiboot signature
>> > + cmpl $0x1badb002, %ss:(DATA_ADDR + 0x50)
>> > + jz 1f
>> [...]
>>
>> if there is no objection, I'd like to check in this patch.
>
> I don't like that you hardcode 0x1badb002. Could you use the macro from
> multiboot.h ?
>
> Also for the comments, I think /* */ is preferred (at least, it is consistent
> with the rest of GRUB).
And do not forget "." :-)
--
Marco
Re: Compiling grub2 on *BSD?, walt, 2008/01/26
- Re: Compiling grub2 on *BSD?, Robert Millan, 2008/01/27
- Re: Compiling grub2 on *BSD?, jakllsch, 2008/01/29
- Re: Compiling grub2 on *BSD?, Robert Millan, 2008/01/29
- Re: Compiling grub2 on *BSD?, jakllsch, 2008/01/29
- Re: Compiling grub2 on *BSD?, Marco Gerards, 2008/01/30
- Re: Compiling grub2 on *BSD?, Robert Millan, 2008/01/30
- Re: Compiling grub2 on *BSD?, walt, 2008/01/30
- Re: Compiling grub2 on *BSD?, Robert Millan, 2008/01/30