Re: RDB partition tables in AROS

[Kalamatee]

Alain wrote ..

>Here is a diff againt our svn repository. We have grub2 version 1.96 here.
 

Youve been busy =D

>The changes log:
>- recognize RDB partion tables inside MBR, this is needed for AROS to boot on a PC
>- fix AFFS filesystem for AROS
>- minor bug fix in SFS: count of nodes in extent-btree is written as big endian on disk
>- fixed gensymlist.sh to let us build with a compiler command having arguments
 

The only things that come to mind currently are ..

 

# The support shouldnt be limited to grub2 compiled on AROS only .. it should be possible to take grub2 from any linux flavour and so long as the modules are loaded and the correct grub.cfg entries present, load AROS from MBR embedded RDB/SFS partitions. (my comment on the #AROS IRC channel about the ifdef __AROS__'s)

 

# Some of the code appears to "expect" the correct modules to be loaded rather than check that they are? not sure how you should do this correctly but hopefully someone here can point out what needs corrected.

 

# AFAIK SFS can be in big or little endian so the code should check this before doing "grub_uint16_t nodescount = grub_be_to_cpu16(tree->nodes);"

 

..  Does this make sense?