--- Begin Message ---
|
Subject: |
Re: [PATCH] Use hfs case ordering - another try |
|
Date: |
Mon, 23 Mar 2009 12:37:54 +0100 |
On Mon, 2009-03-23 at 04:23 +0100, Jordi Mallach wrote:
>
> On Mon, Mar 09, 2009 at 01:37:14PM -0400, Pavel Roskin wrote:
> > Hello!
> >
> > It's a shame the discussion about hfs got nowhere. I've made another
> > patch. I didn't look at the Linux hfs sources or at any previous
> > patches. I took the case ordering table from hfsutils 3.2.6, which is
> > licensed under GPL v2 or newer. Then I ran the table through a simple
> > program to make it more readable (attached for reference). The values
> > in the table have been normalized to avoid gaps. Values for equal
> > characters are initialized on the same line for readability.
>
> Thanks for rescuing this fix!
>
> Felix uploaded a new GRUB snapshot which should include this patch.
>
> However, I'm having the same boot problems as before. I've installed
> the new version of GRUB to OF, and when I boot I get the known "initrd:
> command not found" error.
>
> Furthermore, the search command still appears to fail on at least Apple
> OF, and if it's in my boot commandlist, it'll set root to an invalid device,
> making the boot fail with "you need to load the kernel first".
>
> Has anyone else had success with this patch in Debian or using SVN/Git code,
> on PPC?
I didn't get around to trying Pavel's patch, but from your description
it most likely didn't fix the problem properly. Do grub2 file access
commands like hexdump or cat work for special filenames like _linux.mod?
Looking at Pavel's patch, one problem that jumps out immediately is that
it doesn't handle the string lengths correctly. HFS strings aren't
zero-terminated, so grub_hfs_cmp_catkeys() needs to make sure it only
compares characters up to the length of min(k1->strlen, k2->strlen) and
if they all match, return k1->strlen - k2->strlen.
I'm not sure that's what causes your problem though Jordi, but anyway,
why wasn't I CC'd on the new patch? :(
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
--- End Message ---