Re: [PATCH]: Fix fs modules on sparc64 build with newer gcc

[Pavel Roskin]

On Sat, 2009-04-11 at 01:27 -0700, David Miller wrote:
> Newer versions of gcc emit references to libgcc internal
> functions __bswapsi2 and __bswapdi2 when building ufs and
> some other filesystem modules on sparc64.
> 
> Unfortunately older versions of gcc lack these symbols in
> libgcc so we can't export them universally, we have to check
> for it using configure link tests.
> 
> I commited this under the "trust dave with sparc stuff" rule.
> Let me know if it that wasn't appropriate in this case :-)

Actually, changes to configure.ac affect other users as well.  Users of
other architectures would have to run those checks.

I would try to use weak functions or something like that.  Failing that,
I would add a check for affected architectures only.  Even if that would
make the script longer, it would make it clear which architectures need
the check, which is probably a good idea.

> I also rebuild configure when commiting these changes.

I see that configure and config.h.in we built by different versions of
autoconf.  That's likely to break.

I would run autogen.sh and commit all changed files after examining the
changes.  As a courtesy to others, I install the same version of
Autoconf that the current configure script was generated with.

Adding or removing files means that DISTLIST will change.  That should
be committed as well.

Personally, I would remove all files generated by autogen.sh from the
repository.  But I don't want to do something that is inconvenient to
others.  The issue was discussed in the past and the decision was to
keep those files.

-- 
Regards,
Pavel Roskin