Re: [PATCH] Use symbol database to maintain module dependence

[Vladimir 'phcoder' Serbinenko]

symdb code seems to duplicate your list code. Perhaps you could reuse the file from kernel thus making maintaining easier
I liked the file modsym.lst: it gives clear view of symbols.
This patch brek grub-install because moddep.lst isn't copied correctly
Also check that 
Also in some places I saw 
+  while (n)
+    {
+      modified += remove_string (&u->cur_mods, (char *) n->name);
Here perhaps modified = remove_string (..) || modified; is more appropriate
+      n = n->next;
+    }

+  remove MODULES          remove modules from the symbol databsae\n\
Typo

On Mon, Apr 27, 2009 at 8:33 AM, Bean <address@hidden> wrote:

Hi,

ping ?

On Tue, Apr 21, 2009 at 5:11 AM, Bean <address@hidden> wrote:
> Hi,
>
> This patch add a new tool grub-symdb to manage symbol database and
> update module dependence as required. The build process is greatly
> simplified, moddep.lst, def-*.lst, und-*.lst are not generated
> anymore. grub-symdb will read the module files and update modsym.lst
> and moddep.lst automatically.
>
> --
> Bean
>

--
Bean


_______________________________________________
Grub-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/grub-devel

-- 
Regards
Vladimir 'phcoder' Serbinenko