[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] improve error messages in grub-setup
From: |
Robert Millan |
Subject: |
Re: [PATCH] improve error messages in grub-setup |
Date: |
Sun, 3 May 2009 22:54:29 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, May 03, 2009 at 01:04:33PM -0400, Pavel Roskin wrote:
> On Sun, 2009-05-03 at 18:55 +0200, Robert Millan wrote:
>
> > Agreed. It's no harm to add --force for users who are stuck in such
> > layouts.
> >
> > Here's a new patch.
>
> I don't see the "force" variable affecting anything in setup() other
> than output.
There is, see:
+ grub_util_warn ("Embedding is not possible. GRUB can only be installed in
this "
+ "setup by using blocklists. However, blocklists are
UNRELIABLE and "
+ "its use is discouraged.");
+ if (! force)
+ grub_util_error ("If you really want blocklists, use --force.");
The first is always displayed, the latter only when we don't have --force
> grub_util_warn() doesn't set any flag that there have been
> warnings.
That's an option, too. But it would preclude the possibility of issuing
warnings for which we don't want to require --force (i.e. lesser evils).
I wonder if that would be a problem?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."