[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Provide grub_dl_ref() and grub_dl_unref() for GRUB_UTIL
From: |
David Miller |
Subject: |
Re: [PATCH] Provide grub_dl_ref() and grub_dl_unref() for GRUB_UTIL |
Date: |
Mon, 04 May 2009 17:15:52 -0700 (PDT) |
From: Pavel Roskin <address@hidden>
Date: Mon, 04 May 2009 20:13:24 -0400
> Hello!
>
> The GRUB code is full of constructs like
>
> #ifndef GRUB_UTIL
> grub_dl_ref (my_mod);
> #endif
>
> It's better to avoid having source files littered with preprocessor
> conditionals. This patch implements grub_dl_ref() and grub_dl_unref()
> as inline functions when GRUB_UTIL is defined.
>
> I'm not using the unused attribute to match the existing signature of
> those functions.
>
> ChangeLog:
> * include/grub/dl.h [GRUB_UTIL]: Provide inline implementations
> of grub_dl_ref() and grub_dl_unref(). Remove preprocessor
> conditionals around all callers.
Change looks great, but probably you want to explicitly mention
all of the C files where you got rid of the CPP conditional
tests.