[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] restructure code flow in grub-setup / setup()
From: |
Robert Millan |
Subject: |
[PATCH] restructure code flow in grub-setup / setup() |
Date: |
Sun, 10 May 2009 11:47:23 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
This restructures code flow in the setup() function to make it easier to
work with. The current layout is really confusing; instead, I propose
a "try-fail" approach, like:
if (problem1)
{
grub_util_warn ("warning1");
goto unable_to_embed;
}
if (problem2)
{
grub_util_warn ("warning2");
goto unable_to_embed;
}
[...]
To make my patch more readable I intentionally omitted indentation changes
from it (which I'll add when committing, of course).
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
grub_setup_flow.diff
Description: Text Data
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] restructure code flow in grub-setup / setup(),
Robert Millan <=