[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] add a --disk-module option to grub-install
From: |
Vladimir 'phcoder' Serbinenko |
Subject: |
Re: [PATCH] add a --disk-module option to grub-install |
Date: |
Fri, 5 Jun 2009 23:26:07 +0200 |
- # generic method (used on coreboot)
+ if [ "$disk_module" = ata ] ; then
+ # generic method (used on coreboot and ata mod)
uuid="`$grub_probe --target=fs_uuid --device ${grub_device}`"
if [ "x${uuid}" = "x" ] ; then
- echo "UUID needed on this platform, but the filesystem
containing ${grubdir} does not support UUIDs." 1>&2
+ echo "UUID needed on this platform and with ata mod, but
the filesystem containing ${grubdir} does not support UUIDs." 1>&2
IMO it would be better to remove "on this platform" part.
Otherwise patch looks ok, I will test it tomorrow
On Thu, Jun 4, 2009 at 11:07 PM, Felix Zielcke<address@hidden> wrote:
> Am Donnerstag, den 04.06.2009, 20:57 +0200 schrieb Felix Zielcke:
>> Here's a patch which adds --disk-module to grub-install for i386-pc to
>> make it easier for users to try out ata mod instead of biosdisk.
>
> Args I forgot the actual parsing of the option.
> --
> Felix Zielcke
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
>
--
Regards
Vladimir 'phcoder' Serbinenko