Re: [PATCH] UUID support for UFS

[Pavel Roskin]

On Tue, 2009-07-21 at 15:03 +0200, Vladimir 'phcoder' Serbinenko wrote:
> +      grub_sprintf (*uuid, "%08lx%08lx",
> +                   (unsigned long) grub_le_to_cpu32 (data->sblock.uuidhi),
> +                   (unsigned long) grub_le_to_cpu32 (data->sblock.uuidlow));

unsigned long is 64-bit on x86_64.  unsigned int would do just fine
here.

Also, I don't see where this notation is used.  The FreeBSD dumpfs
prints two numbers in hex with a space between them.  On Linux, udev
doesn't create entries for UFS partitions under /dev/disk/by-uuid.
Linux kernel doesn't print UUID at all.

I would add a dash between the numbers to make it more readable unless
there is a precedent where the dash is not used.

Apart from that, the code looks good and the result matches the output
of dumpfs.

-- 
Regards,
Pavel Roskin