Re: [PATCH] Fix CPUID documentation and return values

[Felix Zielcke]

Am Freitag, den 31.07.2009, 18:26 +0200 schrieb Robert Millan:
> On Fri, Jul 31, 2009 at 06:19:11PM +0200, Felix Zielcke wrote:
> > Am Freitag, den 31.07.2009, 18:07 +0200 schrieb Robert Millan:
> > > On Tue, Jul 28, 2009 at 11:05:37PM +0200, Vladimir 'phcoder' Serbinenko 
> > > wrote:
> > > > On Tue, Jul 28, 2009 at 8:15 PM, Robert Millan<address@hidden> wrote:
> > > > > On Tue, Jul 28, 2009 at 01:03:51AM +0200, Vladimir 'phcoder' 
> > > > > Serbinenko wrote:
> > > > >> Hello. CPUID command currently doesn't return a real grub_err_t and
> > > > >> errors aren't set which doesn't fit in grub2's design.
> > > > >> Addirionally "help cpuid" doesn't give really useful info. So for
> > > > >> future expandability and less confusion I propose the attached patch
> > > > >> partially based on original patch by Robert Millan
> > > > >
> > > > > Hi,
> > > > >
> > > > > I don't remember about this patch.  I assume I wrote it in 2007 when
> > > > > merging cpuid support for first time.
> > > > Yes, it is.
> > > > >  Any idea why it wasn't it committed
> > > > > back then?
> > > > >
> > > > None. Yoshinori K Okuji approved it here:
> > > > http://lists.gnu.org/archive/html/grub-devel/2007-05/msg00148.html
> > > 
> > > I vaguely recall having disabled it because there was some issue with
> > > scripting.  Assuming it's working properly now, I have no objection with
> > > it.
> > > 
> > 
> > There was one.
> > if [ 0=1 ] ; then echo t ; else echo f ; fi
> > did print t but then also `error: false'
> > This is now fixed.
> 
> But the cpuid CLI worked differently, IIRC
> 

Ah in the thread you said that
`if cpuid --long-mode; then ...; else ...; fi'
doestn't work.

But I just tested this with 
`if cpuid --long-mode; then echo true; else echo false; fi'
in qemu and in 32bit I get false and in 64bit I get true.



-- 
Felix Zielcke
Proud Debian Maintainer