[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA
From: |
Robert Millan |
Subject: |
Re: [PATCH] Fail gracefuly when attempting to load 64-bit kFreeBSD on IA32 CPU |
Date: |
Fri, 9 Oct 2009 20:25:53 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
I didn't notice this mail untill a few minutes ago (was still in fetch
queue), so my first patch was already checked in.
On Fri, Oct 09, 2009 at 01:10:12AM +0200, Vladimir 'phcoder' Serbinenko wrote:
> >Index: include/grub/i386/cpuid.h
> >===================================================================
> >--- include/grub/i386/cpuid.h (revision 0)
> >+++ include/grub/i386/cpuid.h (revision 0)
>
> This file doesn't follow convention of having an ifdef around the file
Thanks, I've added it now.
> >+extern unsigned char grub_cpuid_has_longmode;
> I don't like it being declared as a variable: user may inadvertently assign a
> value to it. I would be more confortable with a function
I tend to prefer a (const) function too, but this required some restructuring
in cpuid.c so for 1.97 I opted for keeping the changes minimal.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."