[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Refuse to install on XFS destroying its superblock
From: |
Robert Millan |
Subject: |
Re: [PATCH] Refuse to install on XFS destroying its superblock |
Date: |
Sat, 17 Oct 2009 14:00:13 +0200 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> Robert Millan wrote:
> > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko
> > wrote:
> >
> >> 2009-10-16 Vladimir Serbinenko <address@hidden>
> >>
> >> + * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock.
> >> + (options): New option --destroy-xfs.
> >> + (main): Handle --destroy-xfs.
> >>
> >
> > I gave this some more thought, and I think this could be less ad-hoc. We're
> > treating XFS as if it were a "weird", unique thing just because it isn't
> > biased
> > towards DOS-style boot like most filesystems are.
> >
> > Instead, I've done something more generic, using our standard filesystem
> > probing engine which should be more reliable than a single memcmp.
> >
> >
> The danger is that fs_probe may reject filesystem as valid just because
> it's newer than expected.
What do you mean with "reject filesystem as valid"?
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
- Re: [PATCH] Refuse to install on XFS destroying its superblock, (continued)
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Jordi Mallach, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/16
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock,
Robert Millan <=
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Felix Zielcke, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, address@hidden, 2009/10/17
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/18
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/18
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/18
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/20
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Vladimir 'phcoder' Serbinenko, 2009/10/20
- Re: [PATCH] Refuse to install on XFS destroying its superblock, Robert Millan, 2009/10/24