Re: [PATCH,HURD] Fix root device passing

[Samuel Thibault]

Felix Zielcke, le Mon 02 Nov 2009 20:06:19 +0100, a écrit :
> Am Montag, den 02.11.2009, 19:53 +0100 schrieb Samuel Thibault:
> > Colin Watson, le Mon 02 Nov 2009 18:50:43 +0000, a écrit :
> > > 'multiboot ${kernel} root=device:${GRUB_DEVICE#/dev/}' would be simpler
> > > and quicker.
> > 
> > And will not work on some systems.
> > 
> > Samuel
> 
> Which ones?

Solaris for instance.

> I just looked in POSIX.1-2008 and it defines it.
> Both bash and dash supports it.

Fortunately, yes.

> Note that 10_hurd only gets installed if the host kernel is HURD.

Ah, then ok.

> Is there any HURD based distribution avaible besides Debian?

There is the GNU distribution yes.  In any case it's probably safe to
assume that a GNU system uses at least a POSIX2008-compliant dash or
posh.  Here is an updated patch.

Samuel

2009-11-02  Samuel Thibault  <address@hidden>

        * util/grub.d/10_hurd.in: Drop /dev/ prefix from root device path before
        giving it to GNU Mach.

Index: util/grub.d/10_hurd.in
===================================================================
--- util/grub.d/10_hurd.in      (révision 2677)
+++ util/grub.d/10_hurd.in      (copie de travail)
@@ -73,7 +73,7 @@
 EOF
 prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} | sed -e "s/^/\t/"
 cat << EOF
-       multiboot ${kernel} root=device:${GRUB_DEVICE}
+       multiboot ${kernel} root=device:${GRUB_DEVICE#/dev/}
 EOF
 prepare_grub_to_access_device ${GRUB_DEVICE} | sed -e "s/^/\t/"
 cat << EOF