Re: [RFC][PATCH] Basic unit testing support for GRUB

[Felix Zielcke]

Am Freitag, den 13.11.2009, 23:15 +0530 schrieb BVK:
> Hi,
> 
> 
> Attached is the (experimental branch) patch for unit testing that I
> have in mind for GRUB.  Please let me know your comments.
> 
> It provides "make check" target which would build and execute test
> programs from "tests" directory.  We can write small programs to test
> specific functions in GRUB.  For example, attached patch has sample
> program comparing grub_sprintf behavior against standard sprintf
> output (from glibc).
> 
> Note that it currently has few gotchas, like using TARGET_CC instead
> of BUILD_CC, no support for XPASS, XFAIL tests, etc.

Thanks for your work.
A really useful test and hopefully not complicated to implement would be
if the config generated by grub-mkconfig (with e.g. 1 fake linux kernel)
can be parsed by sh.mod and only uses commands listed in commands.lst

Reasoning:
With current trunk grub-mkconfig this line ends up in grub.cfg:
  menuentry "Debian, with Linux GNU/Linux" {menuentry "2.6.31-1-amd64, with 
Linux " {     insmod ext2
and of course this totally breaks the parser.

-- 
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer