[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: keyboard layout patches
From: |
Carles Pina i Estany |
Subject: |
Re: keyboard layout patches |
Date: |
Mon, 18 Jan 2010 23:27:26 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Jan/18/2010, Carles Pina i Estany wrote:
> I've done a first version of keyboard_layout. Find a patch attached, or
Thanks to the comments from different people in the thread, I send a new
version.
It does, on from my head:
a) Constants used in util/ and Grub are in a common header file.
b) Use 8 bytes magic file, instead of 7
c) Adds a new command "**" to revert to the default keyboard
d) Don't use popen and use fork + execlp + pipe
e) Change some names that I didn't like
f) Implements a new variable in /etc/grub/default
And some other small bugfixes.
Everything is tested but not f).
The solution of c) is temporary, but I think that good enough for this
stage. When this is in trunk/experimental (I think that can go to trunk
straight away since there isn't major changes, but I give it up to you)
I can implement some other solution.
What else I should change, or some other comment?
Thanks,
--
Carles Pina i Estany
http://pinux.info
keyboard_layout02.patch
Description: Text Data
Re: keyboard layout patches, Carles Pina i Estany, 2010/01/18
Re: keyboard layout patches,
Carles Pina i Estany <=