Re: [PATCH] Multiboot video support

[Michal Suchanek]

2010/1/24 Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden>:
> Robert Millan wrote:
>> On Wed, Jan 20, 2010 at 12:43:38PM +0100, Michal Suchanek wrote:
>>
>>> Shouldn't the structure also include the framebuffer orientation?
>>>
>>> If framebuffer transform support is included in grub it would be good
>>> to pass the orientation the user specified for grub graphics output to
>>> the OS so that the OS console output is displayed the same way
>>> automatically.
>>>
>>
>> Makes sense.  Can you draft a proposal?
>>
>>
> There is a big difference between orientation and the rest of fields:
> orientation is configuration variable whereas other fields are a
> hardware information. We need to draw aline of what we want and what we
> don't want to pass, otherwise, we may end up passing font, background
> images and even logos.
>

Unlike font, background image or logos the orientation of the screen
is hardware property. Unfortunately, few screens allow determining
this property in software so you have to rely on user input in most
cases.

Have you looked at the patch?

The framebuffer transform is represented as a bit field which could be
added to the mode flags.

I am not sure if that is the best approach, though. OSes might refuse
modes with unknown flags and this is not really mode specific so
perhaps separate flags would be better.

Thanks

Michal