grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] transparent file reader


From: Szymon Janc
Subject: Re: [PATCH] transparent file reader
Date: Sun, 28 Feb 2010 22:38:48 +0100
User-agent: KMail/1.12.4 (Linux/2.6.32-2-686; KDE/4.3.4; i686; ; )

Dnia wtorek 16 luty 2010 o 19:16:19 Vladimir 'φ-coder/phcoder' Serbinenko 
napisał(a):

> I like the patch however few comments:
> 1) How are filters ordered?
> 2) How would I selectively disable a filter. E.g. for hexdump or when
> payload expects compressed data?
> 
> +/* Registered filters list.  */
> +static grub_io_filter_t grub_io_filter_list = NULL;
> +
> +void grub_io_register(grub_io_filter_t filter)
> +{
> +   filter->next = grub_io_filter_list;
> +   grub_io_filter_list = filter;
> +}
> +
> 
> list.h can be used for this.

Attached is new version, changes since previous one:
- use list.h
- filter registration is priority based
- filter can be disabled for next open by grub_io_filter_disable()

Interface could be simpler if make it only transparent/non-transparent but 
this is somewhat less flexible. Yet, is it really needed?

-- 
Szymon K. Janc
address@hidden // GG: 1383435

Attachment: transparentio2.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]