[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add submenu support to 10_linux (grub-mkconfig)
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] Add submenu support to 10_linux (grub-mkconfig) |
Date: |
Sat, 03 Mar 2012 15:20:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 |
On 29.02.2012 07:10, Jordan Uggla wrote:
In my first patch I rather stupidly asked gettext for a translation of "%s".
Updated patch below does not have this mistake.
I attach the update on the top of menuid.
I think it would be bad to break every time user changes the
configuration entry. So I'd prefer to remove this option. Now there is
however a problem with migration. I see following possibilities:
1) Check in grub-mkconfig & co that GRUB_DEFAULT/saved_entry from envblk
contains old or old Ubuntu-style entries and if it does add a stanza like:
if [ x"$default" = x"<entry>" ]; then
default="<new name>"
fi
and issue a warning
2) Like (1) but replace a warning with error and issue no stanza
3) Like (1) but perform no check and issue no warning and simply
generate stanzas for all possible entries. Would result in a lot of clutter
4) Like (3) make check independent of stanzas and use it for issuing the
warning
Right now I believe that (1) is the most reasonable
@Colin Watson: given the problems with current Ubuntu submenu patch and
a migration way like in (1) is it possible to replace Ubuntu patch with
Jordan's one for 12.10?
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
submenu.diff
Description: Text Data
- Re: [PATCH] Add submenu support to 10_linux (grub-mkconfig),
Vladimir 'φ-coder/phcoder' Serbinenko <=