[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug
From: |
Andrey Borzenkov |
Subject: |
Re: [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug |
Date: |
Sat, 20 Jul 2013 17:47:57 +0400 |
В Mon, 15 Jul 2013 17:35:15 +0400
Vladimir Testov <address@hidden> пишет:
> diff -Naur grub-new3/grub-core/gfxmenu/gui_list.c
> grub-new4/grub-core/gfxmenu/gui_list.c
> --- grub-new3/grub-core/gfxmenu/gui_list.c 2013-07-15 15:30:26.585116409
> +0400
> +++ grub-new4/grub-core/gfxmenu/gui_list.c 2013-07-15 16:36:34.544169956
> +0400
> @@ -273,16 +273,30 @@
> cwidth -= selbox->get_border_width (selbox);
> selbox->set_content_size (selbox, cwidth, item_height);
>
> - int string_left_offset = self->icon_width + icon_text_space;
> - int string_top_offset = (item_height - (ascent + descent)) / 2 + ascent;
> + int item_left_offset = self->icon_width + icon_text_space;
> + int item_top_offset = (item_height - (ascent + descent)) / 2 + ascent;
[...]
>
> grub_video_rect_t svpsave, sviewport;
> - sviewport.x = sel_leftpad + string_left_offset;
> - sviewport.width = cwidth - string_left_offset;
> + sviewport.x = sel_leftpad + item_left_offset;
> + sviewport.width = cwidth - item_left_offset;
> sviewport.height = item_height;
Is there any reason for renaming? Such changes usually obfuscate main
patch content and better done as separate patch with clear explanation.