Re: [PATCH] arm: fix u-boot port syscall interface va_arg handling (was Re: [PATCH] [ARM] Enable boot module for arm)

[Leif Lindholm]

On Sat, Nov 16, 2013 at 04:19:48PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko 
wrote:
> >> @@ -138,6 +138,7 @@ FUNCTION(grub_uboot_syscall)
> >>         mov     lr, pc
> >>         ldr     pc, grub_uboot_syscall_ptr
> >>         str     r8, gd_backup
> >> +       str     r9, gd_backup + 4
> >>  
> >>         ldr     r8, transition_space
> >>         ldr     lr, transition_space + 4
> >>
> >> Can I push this fix too?
> > 
> > Umm, at second thought - the gd pointer(s) wouldn't be changing.
> > So the correct fix would rather be to 
> > -         str     r8, gd_backup
> > ?
> > 
> Was this tested?

Tested on Ian's qemu, with an "mmc" block device..

/
    Leif