[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH 4/4] efi: On x86-64, align the stack to a 16-byte boundary as required by ABI |
|
Date: |
Tue, 19 Nov 2013 14:32:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 |
On 13.11.2013 03:27, Josh Triplett wrote:
> 2013-11-13 Josh Triplett <address@hidden>
>
> * grub-core/kern/x86_64/efi/startup.S (_start): Align the stack to a
> 16-byte boundary, as required by the x86-64 ABI, before calling
> grub_main. In some cases, GCC emits code that assumes this
> alignment, which crashes if not aligned. The EFI firmware is also
> entitled to assume that stack alignment without checking.
Committed with changes, thanks.
signature.asc
Description: OpenPGP digital signature
- [PATCH 2/4] efi: Fix requests to allocate GRUB_MEMORY_AVAILABLE, (continued)