[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] * grub-core/kern/uboot/init.c (uboot_timer_ms) correct units
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
Subject: |
Re: [PATCH] * grub-core/kern/uboot/init.c (uboot_timer_ms) correct units |
Date: |
Sat, 21 Dec 2013 23:23:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 |
On 15.12.2013 16:23, Ian Campbell wrote:
> From: Ian Campbell <address@hidden>
>
> u-boot's API_GET_TIMER returns the current time in ms by directly exposing the
> internal get_timer which is in ms, which isn't all that clearly documented but
> is obvious from the use within u-boot and is mentioned in
> http://www.denx.de/wiki/U-Boot/TaskTimerAPI.
>
During tests on my raspberry pi, I actually experienced the exact
opposite. On PI timer API is in microseconds.
Are you sure you made no mistake?
> This was put wrong in 4e13e84e56f7 "Fix timer units".
>
> Without this it takes 5000s to count down to the automatic boot of the
> selected
> option (or I assume it would, I never waited...)
>
> Cc: Vladimir 'phcoder' Serbinenko <address@hidden>
> Cc: Leif Lindholm <address@hidden>
> ---
> grub-core/kern/uboot/init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/grub-core/kern/uboot/init.c b/grub-core/kern/uboot/init.c
> index b108de3..2e9d382 100644
> --- a/grub-core/kern/uboot/init.c
> +++ b/grub-core/kern/uboot/init.c
> @@ -66,8 +66,7 @@ uboot_timer_ms (void)
> if (cur < last)
> high++;
> last = cur;
> - return grub_divmod64 ((((grub_uint64_t) high) << 32) | cur,
> - 1000, 0);
> + return (((grub_uint64_t) high) << 32) | cur;
> }
>
> void
>
signature.asc
Description: OpenPGP digital signature