Re: [PATCH] Allow to add/change menu entry class defaults.

[Andrei Borzenkov]

On Tue, Dec 22, 2015 at 6:19 PM, Robin Schneider <address@hidden> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Useful for changing the default access level for menu entries when using
> GRUBs password protection feature.
>
> Ansible role which makes use of this patch:
> https://github.com/debops/ansible-grub/pull/7
>

That's overcomplicated. The first class found wins and you will not
define them unless you have them. So just having

class="$GRUB_..._CLASS --class ..."

is really enough.

> Let me know what you think.
>

I'm not sure I like turning grub-mkconfig into kitchen sink, but yes,
that probably makes sense. It allows easy vendor-specific icons
without need to patch grub every time.

> -CLASS="--class gnu-linux --class gnu --class os --class xen"

I guess "--class xen" should be in front as most specific (unrelated
to your patch).

I have half baked patch lying around that tries to use more sensible
icons in os-prober as well. May be it's time to revisit it.