[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loade
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v3 02/10] xen: reduce number of global variables in xen loader |
Date: |
Thu, 18 Feb 2016 18:13:41 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Feb 18, 2016 at 11:34:49AM +0100, Juergen Gross wrote:
> On 18/02/16 11:22, Daniel Kiper wrote:
> > On Wed, Feb 17, 2016 at 06:19:29PM +0100, Juergen Gross wrote:
> >> The loader for xen paravirtualized environment is using lots of global
> >> variables. Reduce the number by making them either local or by putting
> >> them into a single state structure.
> >>
> >> Signed-off-by: Juergen Gross <address@hidden>
> >
> > Just two nitpicks but in general...
> >
> > Reviewed-by: Daniel Kiper <address@hidden>
> >
> >> ---
> >> grub-core/loader/i386/xen.c | 259
> >> +++++++++++++++++++++++---------------------
> >> 1 file changed, 138 insertions(+), 121 deletions(-)
[...]
> >> - if (!xen_module_info_page)
> >> + if (!xen_state.module_info_page)
> >> {
> >> - n_modules = 0;
> >> - max_addr = ALIGN_UP (max_addr, PAGE_SIZE);
> >> - modules_target_start = max_addr;
> >> - next_start.mod_start = max_addr + xen_inf.virt_base;
> >> - next_start.flags |= SIF_MULTIBOOT_MOD;
> >> + xen_state.n_modules = 0;
> >> + xen_state.max_addr = ALIGN_UP (xen_state.max_addr, PAGE_SIZE);
> >> + xen_state.modules_target_start = xen_state.max_addr;
> >> + xen_state.next_start.mod_start =
> >> + xen_state.max_addr + xen_state.xen_inf.virt_base;
> >
> > Lost one space.
>
> Really? Common indentation style seams to be to use tabs where possible.
> And this is a tab.
Sorry, I have missed that.
Daniel
[PATCH v3 06/10] xen: factor out allocation of special pages into separate function, Juergen Gross, 2016/02/17
[PATCH v3 03/10] xen: add elfnote.h to avoid using numbers instead of constants, Juergen Gross, 2016/02/17
[PATCH v3 10/10] xen: add capability to load p2m list outside of kernel mapping, Juergen Gross, 2016/02/17
[PATCH v3 05/10] xen: factor out p2m list allocation into separate function, Juergen Gross, 2016/02/17